Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid resize on mouse hover (KeyValueTable) #584

Merged
merged 2 commits into from
May 26, 2020

Conversation

smanolloff
Copy link
Contributor

Which problem is this PR solving?

before
The table cell should not resize on hover.
This is quite annoying, esp. with longer messages, where word-wrap gets all messed up.
After the change:
after

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #584 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   93.55%   93.57%   +0.01%     
==========================================
  Files         217      217              
  Lines        5289     5289              
  Branches     1360     1360              
==========================================
+ Hits         4948     4949       +1     
+ Misses        300      299       -1     
  Partials       41       41              
Impacted Files Coverage Δ
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 91.52% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a8406...469b38a. Read the comment docs.

@smanolloff smanolloff changed the title replace display: none with visibility: hidden Avoid resize on mouse hover (KeyValue table) May 25, 2020
@smanolloff smanolloff changed the title Avoid resize on mouse hover (KeyValue table) Avoid resize on mouse hover (KeyValueTable) May 25, 2020
@smanolloff smanolloff force-pushed the avoide-resize-on-hover branch from 58cf0de to bd852b5 Compare May 25, 2020 19:08
Signed-off-by: Simeon Manolov <simeon.manolov@sumup.com>
@smanolloff smanolloff force-pushed the avoide-resize-on-hover branch from bd852b5 to a89506e Compare May 26, 2020 00:07
Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thank you!

@everett980 everett980 merged commit eb6d985 into jaegertracing:master May 26, 2020
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Simeon Manolov <simeon.manolov@sumup.com>

Co-authored-by: Everett <everett980@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants