Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span bar row size fix #599

Merged
merged 1 commit into from
Jul 24, 2020
Merged

span bar row size fix #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ limitations under the License.
/* The size of the indentGuide is based off of the iconWrapper */
padding-right: calc(0.5rem + 12px);
height: 100%;
border-left: 1px solid transparent;
border-left: 3px solid transparent;
display: inline-flex;
}

Expand All @@ -39,15 +39,11 @@ limitations under the License.
}

.SpanTreeOffset--indentGuide.is-active {
/* The size of the indentGuide is based off of the iconWrapper */
padding-right: calc(0.5rem + 11px);
border-left: 0px;
border-left: 3px solid darkgrey;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can get away with just border-color: darkgrey to avoid reproducing the other two characteristics (3px and solid)

}

.SpanTreeOffset--indentGuide.is-active:before {
content: '';
padding-left: 3px;
background-color: darkgrey;
background-color: transparent;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a psuedoelement without content is not generated at all.

Please remove this :before entirely if it is not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding is a part of element size

jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.css

Line 37 in 09d763f

padding-left: 1px;
this is needed to show tiny lines (lines when :not(:hover))

}

.SpanTreeOffset--iconWrapper {
Expand Down