Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve styling of trace statistics selectors #639

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

rubenvp8510
Copy link
Collaborator

Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com

Which problem is this PR solving?

Short description of the changes

  • Made some modification to CSS to match DDG selector styles, attached screenshots

Screenshot from 2020-09-15 12-42-02

@yurishkuro
Copy link
Member

[prettier-lint] packages/jaeger-ui/src/components/TracePage/TraceStatistics/TraceStatisticsHeader.css
[prettier-lint] error Command failed with exit code 1.

@rubenvp8510
Copy link
Collaborator Author

Ups, I ran prettier and I forgot to update the PR

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files         227      227           
  Lines        5902     5902           
  Branches     1483     1483           
=======================================
  Hits         5524     5524           
  Misses        337      337           
  Partials       41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65f944...6caaa1d. Read the comment docs.

@yurishkuro yurishkuro merged commit 7f4c562 into jaegertracing:master Sep 15, 2020
@yurishkuro
Copy link
Member

Thanks!

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve styling of the new Trace Stats view
2 participants