Change UI configuration to a Javascript file

[th3M1ke]

Which problem is this PR solving?

• resolves Change UI configuration to a Javascript file #123

Short description of the changes

• add ability to use JS file as a configuration file
• backend implementation PR: Add ability to use JS file for UI configuration (#123 from jaeger-ui) jaeger#2707

[th3M1ke]

@yurishkuro I remember, that we discuss memoization of the getConfig() function here, but I found one test, which checks for depreciation each time we invoke getConfig(). Is this relevant? What is the use case for this?

[codecov]

Codecov Report

Merging #677 (2b9dadb) into master (551db4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         228      228           
  Lines        5930     5930           
  Branches     1448     1448           
=======================================
  Hits         5588     5588           
  Misses        308      308           
  Partials       34       34           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 551db4c...2b9dadb. Read the comment docs.

[yurishkuro]

but I found one test, which checks for depreciation each time we invoke getConfig(). Is this relevant? What is the use case for this?

Don't know what the use case would be, given that at present the config is static as far as the UI is concerned. Maybe it was envisioning loading (and reloading) the config from the server dynamically? Where is the test?

[th3M1ke]

Test 'processes deprecations every time getConfig is invoked' located 'packages/jaeger-ui/src/utils/config/get-config.test.js:113'

[yurishkuro]

So from what I understand, there were already some historical config format changes such that certain properties have been renamed or moved to different location, and that's what process-deprecation.ts module is fixing. In terms of memoization, the deprecation logic should run at the same time as the UIConfig() function is being called, i.e. the combined result should be memoized. I think the calls to getConfig() are the ones that should be memoized.

[bobrik]

Should the result be memorized? I see a dozen log lines with the following config:

function UIConfig() {
    console.log("loading config");
}

[yurishkuro]

yes - #677 (comment)

[th3M1ke]

@yurishkuro I suggest move the discussion about memoization here #679