Skip to content

Commit

Permalink
[agent] Process data loss stats from clients (#2010)
Browse files Browse the repository at this point in the history
* Collect data loss metrics from clients

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Regenerate thrift

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Prototype

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Upgrade Jaeger client

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Handle wrapped counters

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Fix formatting

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Move to new file

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Shutdown

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Undo unnecessary change

Signed-off-by: Yuri Shkuro <ys@uber.com>

* regenerate

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Add logging

Signed-off-by: Yuri Shkuro <ys@uber.com>

* cleanup

Signed-off-by: Yuri Shkuro <ys@uber.com>

* delint

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Add some tests

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Clean up

Signed-off-by: Yuri Shkuro <ys@uber.com>

* more tests

Signed-off-by: Yuri Shkuro <ys@uber.com>

* More tests

Signed-off-by: Yuri Shkuro <ys@uber.com>

* Reduce nesting

Signed-off-by: Yuri Shkuro <ys@uber.com>

* ignore overflow

Signed-off-by: Yuri Shkuro <ys@uber.com>

* deps

Signed-off-by: Yuri Shkuro <ys@uber.com>

* test

Signed-off-by: Yuri Shkuro <ys@uber.com>

* rename

Signed-off-by: Yuri Shkuro <ys@uber.com>

* comments

Signed-off-by: Yuri Shkuro <ys@uber.com>
  • Loading branch information
yurishkuro authored Jan 15, 2020
1 parent 641dd92 commit 43be2e7
Show file tree
Hide file tree
Showing 32 changed files with 836 additions and 95 deletions.
41 changes: 21 additions & 20 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ required = [

[[constraint]]
name = "github.com/uber/jaeger-client-go"
version = "^2.19.0"
version = "^2.22.0"

[[constraint]]
name = "github.com/uber/jaeger-lib"
Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ docker-hotrod:
GOOS=linux $(MAKE) build-examples
docker build -t $(DOCKER_NAMESPACE)/example-hotrod:${DOCKER_TAG} ./examples/hotrod

.PHONY: run-all-in-one
run-all-in-one:
go run -tags ui ./cmd/all-in-one --log-level debug

.PHONY: build-ui
build-ui:
cd jaeger-ui && yarn install --frozen-lockfile && cd packages/jaeger-ui && yarn build
Expand Down
5 changes: 4 additions & 1 deletion cmd/agent/app/processors/thrift_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ type ThriftProcessor struct {
}
}

// AgentProcessor handler used by the processor to process thrift and call the reporter with the deserialized struct
// AgentProcessor handler used by the processor to process thrift and call the reporter
// with the deserialized struct. This interface is implemented directly by Thrift generated
// code, e.g. jaegerThrift.NewAgentProcessor(handler), where handler implements the Agent
// Thrift service interface, which is invoked with the the deserialized struct.
type AgentProcessor interface {
Process(iprot, oprot thrift.TProtocol) (success bool, err thrift.TException)
}
Expand Down
Loading

0 comments on commit 43be2e7

Please sign in to comment.