Skip to content

Commit

Permalink
Fix Syntax
Browse files Browse the repository at this point in the history
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
  • Loading branch information
mahadzaryab1 committed Sep 29, 2024
1 parent 93e45b9 commit 7be814a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cmd/jaeger/config-kafka-collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ exporters:
kafka:
brokers:
- localhost:9092
topic: env:KAFKA_TOPIC:-jaeger-spans
encoding: env:KAFKA_ENCODING:-otlp_proto
topic: ${env:KAFKA_TOPIC:-jaeger-spans}
encoding: ${env:KAFKA_ENCODING:-otlp_proto}
4 changes: 2 additions & 2 deletions cmd/jaeger/config-kafka-ingester.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ receivers:
kafka:
brokers:
- localhost:9092
topic: env:KAFKA_TOPIC:-jaeger-spans
encoding: env:KAFKA_ENCODING:-otlp_proto
topic: ${env:KAFKA_TOPIC:-jaeger-spans}
encoding: ${env:KAFKA_ENCODING:-otlp_proto}
initial_offset: earliest

processors:
Expand Down
5 changes: 4 additions & 1 deletion cmd/jaeger/internal/integration/kafka_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ func TestKafkaStorage(t *testing.T) {
// has access to the storage and allows the test to query it.
// We reuse E2EStorageIntegration struct to manage lifecycle of the collector,
// but the tests are run against the ingester.
envVarOverrides := map[string]string{"KAFKA_TOPIC": uniqueTopic, "KAFKA_ENCODING": test.encoding}
envVarOverrides := map[string]string{
"KAFKA_TOPIC": uniqueTopic,
"KAFKA_ENCODING": test.encoding,
}

collector := &E2EStorageIntegration{
BinaryName: "jaeger-v2-collector",
Expand Down

0 comments on commit 7be814a

Please sign in to comment.