Skip to content

Commit

Permalink
Revert "Fix failing kafka integration test" (#1077)
Browse files Browse the repository at this point in the history
* Revert "Make the metrics produced by jaeger query scoped to the query component, and generated for all span readers (not just ES) (#1074)"

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
  • Loading branch information
pavolloffay authored Sep 21, 2018
1 parent e8e5962 commit c3278b2
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions plugin/storage/integration/kafka_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,7 @@ func (s *KafkaIntegrationTestSuite) initialize() error {
s.SpanWriter = spanWriter
s.SpanReader = &ingester{traceStore}
s.Refresh = func() error { return nil }
s.CleanUp = func() error {
// TODO close would not work if multiple tests are run
spanConsumer.Close()
return nil
}
s.CleanUp = func() error { return nil }
return nil
}

Expand Down

0 comments on commit c3278b2

Please sign in to comment.