Skip to content

Commit

Permalink
Normalize labels on deprecated CLI flags to (deprecated) use {replace…
Browse files Browse the repository at this point in the history
…ment}

Signed-off-by: Yuri Shkuro <ys@uber.com>
  • Loading branch information
Yuri Shkuro committed Mar 27, 2019
1 parent 99570ec commit cbccc24
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions cmd/agent/app/reporter/tchannel/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ func AddFlags(flags *flag.FlagSet) {
flags.String(
collectorHostPort,
"",
"Deprecated; comma-separated string representing host:ports of a static list of collectors to connect to directly (e.g. when not using service discovery)")
"(deprecated) see --"+tchannelPrefix+hostPort)
flags.Int(
discoveryMinPeers,
defaultMinPeers,
"Deprecated; if using service discovery, the min number of connections to maintain to the backend")
"(deprecated) see --"+tchannelPrefix+discoveryMinPeers)
flags.Duration(
discoveryConnCheckTimeout,
defaultConnCheckTimeout,
"Deprecated; sets the timeout used when establishing new connections")
"(deprecated) see --"+tchannelPrefix+discoveryConnCheckTimeout)
}

// InitFromViper initializes Builder with properties retrieved from Viper.
Expand Down
2 changes: 1 addition & 1 deletion cmd/flags/admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (s *AdminServer) setLogger(logger *zap.Logger) {

// AddFlags registers CLI flags.
func (s *AdminServer) AddFlags(flagSet *flag.FlagSet) {
flagSet.Int(healthCheckHTTPPort, 0, "(deprecated) The http port for the health check service")
flagSet.Int(healthCheckHTTPPort, 0, "(deprecated) see --"+adminHTTPPort)
flagSet.Int(adminHTTPPort, s.adminPort, "The http port for the admin server, including health check, /metrics, etc.")
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/flags/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type logging struct {

// AddFlags adds flags for SharedFlags
func AddFlags(flagSet *flag.FlagSet) {
flagSet.String(spanStorageType, "", fmt.Sprintf(`Deprecated; please use %s environment variable. Run this binary with "env" command for help.`, storage.SpanStorageTypeEnvVar))
flagSet.String(spanStorageType, "", fmt.Sprintf(`(deprecated) please use %s environment variable. Run this binary with "env" command for help.`, storage.SpanStorageTypeEnvVar))
AddLoggingFlag(flagSet)
}

Expand Down
2 changes: 1 addition & 1 deletion plugin/storage/cassandra/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ func addFlags(flagSet *flag.FlagSet, nsConfig *namespaceConfig) {
flagSet.Bool(
nsConfig.namespace+suffixEnableDependenciesV2,
nsConfig.EnableDependenciesV2,
"DEPRECATED: Jaeger will automatically detect the version of the dependencies table")
"(deprecated) Jaeger will automatically detect the version of the dependencies table")
}

// InitFromViper initializes Options with properties from viper
Expand Down

0 comments on commit cbccc24

Please sign in to comment.