all tests passed

jaegertracing · Nov 21, 2024 · d6eeed8 · d6eeed8
1 parent 7b1b3b2
commit d6eeed8
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 70 deletions.
diff --git a/cmd/query/app/apiv3/grpc_handler_test.go b/cmd/query/app/apiv3/grpc_handler_test.go
@@ -83,7 +83,9 @@ func TestGetTrace(t *testing.T) {
 	traceId, _ := model.TraceIDFromString(traceIdLiteral)
 
 	expectedTraceGetParameters := spanstore.TraceGetParameters{
-		TraceID: traceId,
+		TraceID:   traceId,
+		StartTime: &time.Time{},
+		EndTime:   &time.Time{},
 	}
 	tsc.reader.On("GetTrace", matchContext, expectedTraceGetParameters).Return(
 		&model.Trace{
@@ -113,8 +115,8 @@ func TestGetTraceWithTimeWindow(t *testing.T) {
 	traceIdLiteral := "156"
 	traceId, _ := model.TraceIDFromString(traceIdLiteral)
 
-	start_ts := time.Unix(1, 2)
-	end_ts := time.Unix(3, 4)
+	start_ts := time.Unix(1, 2).UTC()
+	end_ts := time.Unix(3, 4).UTC()
 	expectedTraceGetParameters := spanstore.TraceGetParameters{
 		TraceID:   traceId,
 		StartTime: &start_ts,
@@ -132,8 +134,8 @@ func TestGetTraceWithTimeWindow(t *testing.T) {
 	getTraceStream, err := tsc.client.GetTrace(context.Background(),
 		&api_v3.GetTraceRequest{
 			TraceId:   traceIdLiteral,
-			StartTime: &types.Timestamp{Seconds: 1, Nanos: 2},
-			EndTime:   &types.Timestamp{Seconds: 3, Nanos: 4},
+			StartTime: start_ts,
+			EndTime:   end_ts,
 		},
 	)
 	require.NoError(t, err)

diff --git a/cmd/query/app/internal/api_v3/query_service.pb.go b/cmd/query/app/internal/api_v3/query_service.pb.go