Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Simplify gRPC server tests #1483

Closed
yurishkuro opened this issue Apr 22, 2019 · 0 comments · Fixed by #1509
Closed

[query] Simplify gRPC server tests #1483

yurishkuro opened this issue Apr 22, 2019 · 0 comments · Fixed by #1509
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Apr 22, 2019 •
edited
Loading

per this review: #1307 (review)
@yurishkuro yurishkuro mentioned this issue Apr 22, 2019
Merged
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Apr 22, 2019
stefanvassilev added a commit to stefanvassilev/jaeger that referenced this issue Apr 30, 2019
@stefanvassilev
Simplify grpc_hanlder_test.go
74e4deb 
Resolves jaegertracing#1483

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
@stefanvassilev stefanvassilev mentioned this issue Apr 30, 2019
Merged
stefanvassilev added a commit to stefanvassilev/jaeger that referenced this issue May 1, 2019
@stefanvassilev
Simplify grpc_hanlder_test.go
28e7c7a 
Resolves jaegertracing#1483

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
stefanvassilev added a commit to stefanvassilev/jaeger that referenced this issue May 1, 2019
@stefanvassilev
Simplify grpc_hanlder_test.go
cac8496 
Resolves jaegertracing#1483

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
yurishkuro pushed a commit that referenced this issue May 2, 2019
@stefanvassilev @yurishkuro
Simplify grpc_hanlder_test.go (#1509)
3fff102 
* Simplify grpc_hanlder_test.go

Resolves #1483

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>

* Fix indentation

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>

* Address PR comments

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>

* Improve error assertions

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>

* Fix fmt errors

Signed-off-by: stefan vassilev <stefanvassilev1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify grpc_hanlder_test.go stefanvassilev/jaeger
1 participant
@yurishkuro