Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go build -trimpath #2063

Closed
yurishkuro opened this issue Feb 7, 2020 · 0 comments · Fixed by #2064
Closed

Use go build -trimpath #2063

yurishkuro opened this issue Feb 7, 2020 · 0 comments · Fixed by #2064
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

https://speakerdeck.com/campoy/the-state-of-go-2020?slide=47

It should make stack traces more readable.
@ghost ghost added the needs-triage label Feb 7, 2020
@yurishkuro yurishkuro added good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement and removed needs-triage labels Feb 7, 2020
kadern0 added a commit to kadern0/jaeger that referenced this issue Feb 10, 2020
@kadern0
Added -trimpath option to go build
18d9e07 
Fixes jaegertracing#2063

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
@kadern0 kadern0 mentioned this issue Feb 10, 2020
Merged
kadern0 added a commit to kadern0/jaeger that referenced this issue Feb 10, 2020
@kadern0
Added -trimpath option to go build
87d1798 
Fixes jaegertracing#2063

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Signed-off-by: kaderno <kaderno@gmail.com>
yurishkuro pushed a commit that referenced this issue Feb 10, 2020
@kadern0
Added -trimpath option to go build (#2064)
a8d76b0 
* Added -trimpath option to go build

Fixes #2063

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Signed-off-by: kaderno <kaderno@gmail.com>

* Added trimpath option to go build

Defined variable per suggestion of @yurishkuro

Signed-off-by: kaderno <kaderno@gmail.com>

* Updated last go build command

Signed-off-by: Pablo Caderno <kaderno@gmail.com>
Signed-off-by: kaderno <kaderno@gmail.com>

* Changed variable order

Signed-off-by: kaderno <kaderno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added -trimpath option to go build kadern0/jaeger
1 participant
@yurishkuro