Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add Elasticsearch helper binaries to GitHub Releases #5499

Closed
iinuwa opened this issue May 29, 2024 · 2 comments · Fixed by #5501
Closed

[Feature]: Add Elasticsearch helper binaries to GitHub Releases #5499

iinuwa opened this issue May 29, 2024 · 2 comments · Fixed by #5501
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@iinuwa
Copy link

iinuwa commented May 29, 2024

Requirement

We automate installation of Jaeger with Ansible using the Linux AMD64 binaries. We use the es-index-cleaner and es-rollover binaries, but we have to build them ourselves since they're not included in the repo. Is it possible to include those binaries the release packages?

Problem

The Jaeger helper tools for Elasticsearch are only provided as container images, not as binaries to download.

Proposal

A couple ways of accomplishing this are:

  • Include the built Elasticsearch tools in the tarfiles (would increase size of each tarfile)
  • Add a separate set of tarfiles for the helper tools (would increase the number of tarfiles, signatures, SBOMs in the release list etc.)

Open questions

No response

@yurishkuro
Copy link
Member

I think a separate tools tar would be better. The changes need to happen in scripts/package-deploy.sh (we already build all the binaries in that workflow, but only core runtime components are included in the tar).

Curious - why can't you run Docker images? Ansible is capable of running containers.

@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels May 30, 2024
yurishkuro pushed a commit that referenced this issue Jun 1, 2024
## Which problem is this PR solving?
- Resolves #5499 
## Description of the changes
- Add the es helpers to scripts/package-deploy.sh

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
varshith257 pushed a commit to varshith257/jaeger that referenced this issue Jun 2, 2024
## Which problem is this PR solving?
- Resolves jaegertracing#5499 
## Description of the changes
- Add the es helpers to scripts/package-deploy.sh

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
@iinuwa
Copy link
Author

iinuwa commented Jun 6, 2024

Saw that this request is completed, thank you @FlamingSaint and @yurishkuro!

Curious - why can't you run Docker images? Ansible is capable of running containers.

Yeah, Ansible can do that, but when it comes to containers, for us it's another layer of unnecessary complexity. We want to run these services as unprivileged services, which systemd makes easy. Running an unprivileged container as a service requires setting up user and network namespaces and imports a whole extra OS (albeit fairly small). We already have to configure trust systemd, so there's no reason to also trust and configure Alpine and the Docker daemon/Podman. Ultimately, it introduces enough complexity and security concerns into our environment to make it not worth the trouble.

I recognize that other environments heavily rely on containers, so tacking on one more container service makes perfect sense in those environments. That just doesn't happen to be the case for us. (We do have an on-prem Docker cluster running, and I have maintained it for years, but we haven't derived enough benefit to continue to run containers in our environment and plan to shut it down.)

Thanks again for supporting this deployment strategy, and for the rest of the work you do on Jaeger! This will be big help for our development process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants