-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance e2e test for HotROD #5735
Labels
area/otel
docker
Pull requests that update Docker code
enhancement
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
Comments
yurishkuro
added
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
good first issue
Good for beginners
labels
Jul 12, 2024
dosubot
bot
added
area/otel
docker
Pull requests that update Docker code
enhancement
labels
Jul 12, 2024
when i run hotrod container it shows this
|
@yurishkuro I think it is trying to hit |
probably same issue as here #5734 |
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Jul 17, 2024
## Which problem is this PR solving? - #5735 ## Description of the changes - added docker-compose file to test hotrod so that is can connect to jaeger ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: mehul gautam <mehulsharma4786@gamil.com> Co-authored-by: mehul gautam <mehulsharma4786@gamil.com>
FlamingSaint
pushed a commit
to FlamingSaint/jaeger
that referenced
this issue
Jul 20, 2024
## Which problem is this PR solving? - jaegertracing#5735 ## Description of the changes - added docker-compose file to test hotrod so that is can connect to jaeger ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: mehul gautam <mehulsharma4786@gamil.com> Co-authored-by: mehul gautam <mehulsharma4786@gamil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/otel
docker
Pull requests that update Docker code
enhancement
good first issue
Good for beginners
help wanted
Features that maintainers are willing to accept but do not have cycles to implement
The existing CI test for HotROD
scripts/hotrod-integration-test.sh
only checks that the HotROD web UI is being served after runningdocker compose
. Since OTEL Collector release v0.105 there was a change where OTLP receivers started usinglocalhost
as the default host to listen to (see #5734). This breaks visibility of Jaeger endpoints from HotROD app, but our CI tests did not fail, becausescripts/hotrod-integration-test.sh
doesn't actually check if the trace is successfully submitted to Jaeger.We can do better. While we cannot simulate a click on the UI button in the test (technically, we can with a headless browser), we can still execute a request against HotROD's
frontend
service endpoint, which will trigger a trace generation into Jaeger. The endpoint should also return the trace ID in the response headers. Using that trace ID the test can poll Jaeger query for that trace, checking that the expected number of spans is present (retry until that number is returned or until a global timeout is reached, e.g. 5min).The text was updated successfully, but these errors were encountered: