Use Go 1.11 in Travis #1104
Merged
Use Go 1.11 in Travis #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Isaac Hier <isaachier@gmail.com>
isaachier
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
|
I've never seen this error before, looks like they've improved the race detector for 1.11. Created a ticket for this: #1106. Gonna block this until the test is fixed or else CI will be a pain. |
|
Ya IDK how patch version is decided in Travis CI. |
Signed-off-by: Isaac Hier <ihier@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
======================================
Coverage 100% 100%
======================================
Files 140 140
Lines 6622 6622
======================================
Hits 6622 6622
Continue to review full report at Codecov.
|
|
Fixes #1106. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproposing this now that golang/go#27778 has been fixed.