[Storage] Emit spans for elastic storage backend #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annanay25
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
yurishkuro
reviewed
Oct 18, 2018
Codecov Report
@@ Coverage Diff @@
## master #1128 +/- ##
======================================
Coverage 100% 100%
======================================
Files 144 144
Lines 6804 6822 +18
======================================
+ Hits 6804 6822 +18
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Oct 19, 2018
annanay25
force-pushed
the
emit-spans-for-es
branch
from
43a2ab8 to
1d5312f
Compare
|
I'm restarting the CI for this PR, but I suspect the failure might actually be related to this change. |
|
@jpkrohling the CI test has passed, could you review the changes? |
|
pleas ensure full test coverage |
added 4 commits
November 11, 2018 19:37
Signed-off-by: Annanay <annanay.a@media.net>
Signed-off-by: Annanay <annanay.a@media.net>
Signed-off-by: Annanay <annanay.a@media.net>
Signed-off-by: Annanay <annanay.a@media.net>
annanay25
force-pushed
the
emit-spans-for-es
branch
from
1d5312f to
31c6a9d
Compare
|
Patch updated. @yurishkuro |
yurishkuro
approved these changes
Nov 11, 2018
|
Thank you, @annanay25 ! If you are using Jaeger in your organization, please consider commenting on #207. |
|
@yurishkuro thanks! I'll look into the survey soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft, aims to fix #1043
Which problem is this PR solving?
Short description of the changes