-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 1.8 #1170
Prepare release 1.8 #1170
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
======================================
Coverage 100% 100%
======================================
Files 144 144
Lines 6822 6839 +17
======================================
+ Hits 6822 6839 +17
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
- Rename `params.Factory` to `params.MetricFactory` ([#1146](https://github.com/jaegertracing/jaeger/pull/1146), [@vprithvi](https://github.com/vprithvi)) | ||
- Fix child span context while tracing cassandra queries ([#1131](https://github.com/jaegertracing/jaeger/pull/1131), [@annanay25](https://github.com/annanay25)) | ||
- Support tracer env based initialization in hotrod ([#1115](https://github.com/jaegertracing/jaeger/pull/1115), [@eundoosong](https://github.com/eundoosong)) | ||
- Deadlock detector hack for Kafka driver instability ([#1087](https://github.com/jaegertracing/jaeger/pull/1087), [@vprithvi](https://github.com/vprithvi)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should include #1134. I did a master merge to see if the build is clean.
Can we also get jaegertracing/jaeger-ui#263 resolved and include it in this release? We would like to have it in 1.8 |
I expect the embedded UI PR to still go through a few review iterations for a few days (and Joe is traveling this week, he may not have a lot of time to look at it). I would suggest not blocking on it. |
Would we be able to do a patch release once the ui change is ready? |
yes, but we might want to do it from a branch off of the 1.8 version, since we're planning to merge other breaking PRs right after the release. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Cool I wanted to check the same. Then I guess we can go ahead and merge this today/tomorrow. The docs are updated jaegertracing/documentation#167. The only missing part is the architecture diagram which can be done later. |
wait, did you want to change the flag by removing the "collector" part? |
I'll hold on doing the release |
Resolves #1150
Signed-off-by: Pavol Loffay ploffay@redhat.com