Do not add indices to not empty alias

[pavolloffay]

Related to #1407

If the init was run after rollover action it would add indices to read and more importantly write alias. The write alias can contain only one index.

python3  esRollover.py init http://localhost:9200
CONDITIONS='{"max_age": "1s"}' python3  esRollover.py rollover http://localhost:9200
python3  esRollover.py init http://localhost:9200

Signed-off-by: Pavol Loffay ploffay@redhat.com

[objectiser]

Shouldn't this be called alias_is_empty?

[pavolloffay]

yes, apart from that is it OK?

[objectiser]

Yes LGTM.

[objectiser]

@pavolloffay One question - just to confirm - the alias name is based on the jaeger instance? So even if the user is using a shared ES cluster, it will only be checking for alias's related to its own jaeger instance?

[pavolloffay]

For shared instance one has to use prefixes

[jpkrohling]

Once @objectiser's comments are addressed, LGTM

[objectiser]

@pavolloffay Ok thanks - that is fine.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@fcf13ca). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #1408   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     164           
  Lines             ?    7502           
  Branches          ?       0           
========================================
  Hits              ?    7502           
  Misses            ?       0           
  Partials          ?       0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf13ca...ca6357b. Read the comment docs.

[pavolloffay]

xdock failed, but it's not related to this PR