Add missing breaking change to the changelog #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon and
vprithvi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1595 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 191 191
Lines 9162 9162
=======================================
Hits 9053 9053
Misses 85 85
Partials 24 24Continue to review full report at Codecov.
|
vprithvi
reviewed
Jun 10, 2019
| * Add Admin port and group all ports in one file ([#1442](https://github.com/jaegertracing/jaeger/pull/1442), [@yurishkuro](https://github.com/yurishkuro)) | ||
|
|
||
| This change fixes issues [#1428](https://github.com/jaegertracing/jaeger/issues/1428), [#1332](https://github.com/jaegertracing/jaeger/issues/1332) and moves all metrics endpoints from API ports to admin ports. It may require re-configuring Prometheus scraping rules. | ||
|
|
There was a problem hiding this comment.
It REQUIRES re-configuring ...
vprithvi
approved these changes
Jun 10, 2019
added 2 commits
June 10, 2019 18:46
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1442 (comment)