Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] Process data loss stats from clients #2010

Merged
merged 23 commits into from
Jan 15, 2020
41 changes: 21 additions & 20 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ required = [

[[constraint]]
name = "github.com/uber/jaeger-client-go"
version = "^2.19.0"
version = "^2.22.0"

[[constraint]]
name = "github.com/uber/jaeger-lib"
Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ docker-hotrod:
GOOS=linux $(MAKE) build-examples
docker build -t $(DOCKER_NAMESPACE)/example-hotrod:${DOCKER_TAG} ./examples/hotrod

.PHONY: run-all-in-one
run-all-in-one:
go run -tags ui ./cmd/all-in-one --log-level debug

.PHONY: build-ui
build-ui:
cd jaeger-ui && yarn install --frozen-lockfile && cd packages/jaeger-ui && yarn build
Expand Down
5 changes: 4 additions & 1 deletion cmd/agent/app/processors/thrift_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ type ThriftProcessor struct {
}
}

// AgentProcessor handler used by the processor to process thrift and call the reporter with the deserialized struct
// AgentProcessor handler used by the processor to process thrift and call the reporter
// with the deserialized struct. This interface is implemented directly by Thrift generated
// code, e.g. jaegerThrift.NewAgentProcessor(handler), where handler implements the Agent
// Thrift service interface, which is invoked with the the deserialized struct.
type AgentProcessor interface {
Process(iprot, oprot thrift.TProtocol) (success bool, err thrift.TException)
}
Expand Down
Loading