Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count received batches from conforming clients #2030

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Emit a separate client_stats.batches_received counter that only counts batches from "conforming" clients (those that provide clientUUID and batchSeqNo). Then the difference between client_stats.batches_sent and client_stats.batches_received counters reflects the data loss due to UDP packet loss.

Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #2030 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   97.41%   97.39%   -0.02%     
==========================================
  Files         207      207              
  Lines       10249    10250       +1     
==========================================
- Hits         9984     9983       -1     
- Misses        221      223       +2     
  Partials       44       44
Impacted Files Coverage Δ
cmd/agent/app/reporter/client_metrics.go 100% <100%> (ø) ⬆️
cmd/query/app/server.go 91.66% <0%> (-2.78%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea26e9...899f8b6. Read the comment docs.

@yurishkuro yurishkuro merged commit f899363 into jaegertracing:master Jan 21, 2020
@yurishkuro yurishkuro deleted the count-received-batches branch January 21, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants