Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jaeger OTEL agent to docker image upload #2227

Merged

Conversation

ning2008wisc
Copy link
Contributor

Signed-off-by: Ning Zhang ning@autonomic.ai

Which problem is this PR solving?

  • As Jaeger OTEL agent was recently introduced, its docker image is currently not uploaded to the jaegertracing docker hub, which may block the deployment of Jaeger OTEL agent.

Short description of the changes

Signed-off-by: Ning Zhang <ning@autonomic.ai>
@ning2008wisc ning2008wisc requested a review from a team as a code owner May 6, 2020 23:28
@ning2008wisc ning2008wisc requested a review from pavolloffay May 6, 2020 23:28
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #2227 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   96.17%   96.16%   -0.01%     
==========================================
  Files         219      219              
  Lines       10632    10632              
==========================================
- Hits        10225    10224       -1     
- Misses        351      353       +2     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 86.84% <0.00%> (-1.76%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 99.20% <0.00%> (-0.80%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0.00%> (ø)
cmd/flags/admin.go 79.36% <0.00%> (+1.58%) ⬆️
cmd/query/app/server.go 94.52% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d7e09...1a5d267. Read the comment docs.

@ning2008wisc ning2008wisc changed the title Add Jaeger OTEL to docker image upload Add Jaeger OTEL agent to docker image upload May 7, 2020
@pavolloffay pavolloffay merged commit f09872e into jaegertracing:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants