Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka receiver flags to ingester #2251

Merged
merged 1 commit into from
May 18, 2020

Conversation

pavolloffay
Copy link
Member

Related to #2250

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay requested a review from a team as a code owner May 18, 2020 11:42
@pavolloffay pavolloffay requested a review from jpkrohling May 18, 2020 11:42
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #2251 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2251   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files         219      219           
  Lines       10648    10650    +2     
=======================================
+ Hits        10240    10242    +2     
- Misses        352      353    +1     
+ Partials       56       55    -1     
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 99.20% <0.00%> (-0.80%) ⬇️
cmd/collector/app/builder_flags.go 100.00% <0.00%> (ø)
cmd/query/app/static_handler.go 88.59% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a1d93...48c8722. Read the comment docs.

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possibly to add a test?

@pavolloffay
Copy link
Member Author

So far we haven't been testing main classes. The options/builder struct with flags should be tested in the original package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants