-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ES dependencies index mapping to JSON template file #2285
Conversation
… file like with span and service indices Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
… json files Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
…and introduce tests for dependencies index / mapping template Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
… is no explicit index creation anymore Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
+ Coverage 96.18% 96.21% +0.02%
==========================================
Files 219 218 -1
Lines 10688 10687 -1
==========================================
+ Hits 10280 10282 +2
+ Misses 352 350 -2
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
@pavolloffay do you want me to close my other PR then? |
@frittentheke yes and thanks for the work you put into it. |
Supersedes #2149
In addition to the main feature implemented in the original PR:
cc) @frittentheke