Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ES dependencies index mapping to JSON template file #2285

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Jun 9, 2020

Supersedes #2149

In addition to the main feature implemented in the original PR:

  • removes the creation of the dep. template from factory - it's not needed as it creates only writer
  • fixes ES integration tests
  • rebased

cc) @frittentheke

… file like with span and service indices

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
… json files

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
…and introduce tests for dependencies index / mapping template

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
… is no explicit index creation anymore

Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
@pavolloffay pavolloffay requested a review from a team as a code owner June 9, 2020 10:39
@pavolloffay pavolloffay requested a review from vprithvi June 9, 2020 10:39
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #2285 into master will increase coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
+ Coverage   96.18%   96.21%   +0.02%     
==========================================
  Files         219      218       -1     
  Lines       10688    10687       -1     
==========================================
+ Hits        10280    10282       +2     
+ Misses        352      350       -2     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
plugin/storage/es/dependencystore/storage.go 90.74% <0.00%> (+5.02%) ⬆️
plugin/storage/es/factory.go 100.00% <100.00%> (ø)
...lugin/sampling/strategystore/adaptive/processor.go 99.20% <0.00%> (-0.80%) ⬇️
cmd/query/app/server.go 94.80% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbeaac...befb364. Read the comment docs.

@frittentheke
Copy link
Contributor

@pavolloffay do you want me to close my other PR then?

@pavolloffay
Copy link
Member Author

@frittentheke yes and thanks for the work you put into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants