-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated grpc-go to v1.29.1 #2445
Updated grpc-go to v1.29.1 #2445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade seems to cover a bunch of breaking changes to client side load balancing in grpc, but since we don't use any of that in the agent, the one change that might affect us is probably this - grpc/grpc#23086
DNS resolutions will now be sorted.
lgtm, modulo the green CI!
test failed
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
This update sent be to a rabbit hole, and I think it requires more effort than I'm willing to invest right now. So, I'm updating this PR to bump it to 1.29.1 instead, which does fix the original bug I was trying to solve. That said, I'll open another issue to track the work for updating gRPC to latest versions and will try to allocate some time to work on it in case we have no volunteers. |
Created #2449 to track the upgrade to 1.31.x |
Codecov Report
@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
- Coverage 95.58% 95.56% -0.02%
==========================================
Files 208 208
Lines 10679 10679
==========================================
- Hits 10207 10205 -2
- Misses 399 400 +1
- Partials 73 74 +1
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: albertteoh <albert.teoh@logz.io>
Closes #2443
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de