Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate certificates to use SANs instead of Common Name #2461
Regenerate certificates to use SANs instead of Common Name #2461
Changes from 3 commits
3b88935
c9fd172
4c71d06
f5d5bfd
f361cda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps instead of writing to the current dir (and accidentally checking in), we could use temp dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about writing PEM files into
$tmp_dir
and then copying into the right place in the source tree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be
exit -1
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe negative numbers are not supported as return codes in bash. But good catch that it should return a non-0 return code.
return
was intentional because this script issource
d, which means it runs within the parent shell.The added benefit of
source
-ing is that theset -ex
that you suggested above will also apply in this script so commands in this script are printed to STDOUT and will also trigger an early exit if something fails.If developers want to call this script separately, it can be run with
source gen-ssl-conf.sh <args...>
.