Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --jaeger.tags CLI flag #2753

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

yurishkuro
Copy link
Member

Resolves part of #2738

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner February 1, 2021 04:50
Signed-off-by: Yuri Shkuro <github@ysh.us>
@mergify mergify bot requested a review from jpkrohling February 1, 2021 04:51
@yurishkuro yurishkuro mentioned this pull request Feb 1, 2021
7 tasks
yurishkuro and others added 2 commits February 1, 2021 00:03
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #2753 (968aee7) into master (9e5acac) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
+ Coverage   95.86%   95.88%   +0.02%     
==========================================
  Files         217      217              
  Lines        9638     9634       -4     
==========================================
- Hits         9239     9238       -1     
+ Misses        329      328       -1     
+ Partials       70       68       -2     
Impacted Files Coverage Δ
cmd/agent/app/reporter/flags.go 100.00% <ø> (+25.00%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 99.07% <0.00%> (-0.93%) ⬇️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5acac...59cd913. Read the comment docs.

@yurishkuro
Copy link
Member Author

@jpkrohling any concerns with the changes to OTEL part?

Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling
Copy link
Contributor

codecov/patch is still running (!!). Will merge on green.

@yurishkuro
Copy link
Member Author

codecov has been glitchy the past few days, the logs already show the report, but status not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants