Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum and maximum tls version support in tls config #3567

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

Ashmita152
Copy link
Contributor

@Ashmita152 Ashmita152 commented Mar 6, 2022

Signed-off-by: Ashmita152 ashmita.bohara@logz.io

Which problem is this PR solving?

Short description of the changes

  • Add support for minimum tls version

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
@Ashmita152 Ashmita152 requested a review from a team as a code owner March 6, 2022 15:14
@Ashmita152 Ashmita152 requested a review from vprithvi March 6, 2022 15:15
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #3567 (f50c4db) into main (df44af3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
+ Coverage   96.47%   96.48%   +0.01%     
==========================================
  Files         264      264              
  Lines       15402    15429      +27     
==========================================
+ Hits        14859    14887      +28     
  Misses        458      458              
+ Partials       85       84       -1     
Impacted Files Coverage Δ
pkg/config/tlscfg/ciphersuites.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/flags.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/options.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df44af3...f50c4db. Read the comment docs.

pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/flags.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/ciphersuites.go Outdated Show resolved Hide resolved
pkg/config/tlscfg/options.go Outdated Show resolved Hide resolved
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
@Ashmita152 Ashmita152 changed the title Add minimum tls version support in tls config Add minimum and maximum tls version support in tls config Mar 7, 2022
yurishkuro
yurishkuro previously approved these changes Mar 7, 2022
pkg/config/tlscfg/options.go Outdated Show resolved Hide resolved
Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
@yurishkuro yurishkuro merged commit 46bced6 into jaegertracing:main Mar 7, 2022
@yurishkuro
Copy link
Member

👏

albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
* Add minimum tls version support in tls config

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>

* Feedbacks

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>

* Add maximum tls version support in tls config

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>

* Feedbacks

Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support specifying minimum TLS version in TLS connection
2 participants