Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sarama to 1.33.0 #3983

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Oct 18, 2022

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Sarama 1.32.0 should not be used https://github.com/Shopify/sarama/blob/main/go.mod#L42

1.33.0 seems to be the latest sarama version that we can use. 1.34.0 does not work due to dependency on the deprecated sarama-cluster.

@pavolloffay pavolloffay requested a review from a team as a code owner October 18, 2022 15:16
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 97.17% // Head: 97.16% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (35cdc53) compared to base (7e673d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
- Coverage   97.17%   97.16%   -0.01%     
==========================================
  Files         295      295              
  Lines       17389    17389              
==========================================
- Hits        16897    16896       -1     
- Misses        396      397       +1     
  Partials       96       96              
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 75.95% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

albertteoh
albertteoh previously approved these changes Oct 18, 2022
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

PR rebased

@yurishkuro yurishkuro merged commit a84b52d into jaegertracing:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants