Use patched version of github.com/opentracing-contrib/go-grpc in HotROD #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportBase: 97.08% // Head: 97.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4210 +/- ##
==========================================
+ Coverage 97.08% 97.09% +0.01%
==========================================
Files 302 302
Lines 17683 17683
==========================================
+ Hits 17168 17170 +2
+ Misses 414 413 -1
+ Partials 101 100 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Feb 22, 2023
…OD (jaegertracing#4210) ## Which problem is this PR solving? - Resolves jaegertracing#4209 ## Short description of the changes - I created a temporary patch branch https://github.com/opentracing-contrib/go-grpc/tree/patch-for-opentelemetry-go-issue-3678 as a workaround for OTEL issue open-telemetry/opentelemetry-go#3678 - Only HotROD code is using this library, our production code is using `grpc-ecosystem/grpc-opentracing` (which seems to be an identical copy, I am not sure why there are two libs, but it came in handy right now) --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
…OD (jaegertracing#4210) ## Which problem is this PR solving? - Resolves jaegertracing#4209 ## Short description of the changes - I created a temporary patch branch https://github.com/opentracing-contrib/go-grpc/tree/patch-for-opentelemetry-go-issue-3678 as a workaround for OTEL issue open-telemetry/opentelemetry-go#3678 - Only HotROD code is using this library, our production code is using `grpc-ecosystem/grpc-opentracing` (which seems to be an identical copy, I am not sure why there are two libs, but it came in handy right now) --------- Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
grpc-ecosystem/grpc-opentracing(which seems to be an identical copy, I am not sure why there are two libs, but it came in handy right now)