Support normalized metric names #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
albertteoh
commented
Jun 29, 2023
| @@ -18,7 +18,7 @@ run-dev: _run-connector | |||
|
|
|||
| # _run-connector is the base target to bring up the system required for SPM using the new OTEL spanmetrics connector. | |||
| .PHONY: _run-connector | |||
| _run-connector: export OTEL_IMAGE_TAG = latest | |||
| _run-connector: export OTEL_IMAGE_TAG = 0.80.0 | |||
There was a problem hiding this comment.
Thought to fix the version for a more reliable user experience.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4555 +/- ##
==========================================
+ Coverage 97.03% 97.05% +0.02%
==========================================
Files 301 301
Lines 17817 17837 +20
==========================================
+ Hits 17289 17312 +23
+ Misses 423 421 -2
+ Partials 105 104 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Jun 29, 2023
|
DCO? |
Ah, I must have missed signing one commit. Should be good now, thanks. |
|
Thanks for a fast fix. I'll be trying it out right away. 🚀 |
afzal442
pushed a commit
to Cloud-Hacks/jaeger
that referenced
this pull request
Jul 10, 2023
## Which problem is this PR solving? - Resolves jaegertracing#4547 ## Short description of the changes - Adds the following boolean parameters to declaratively determine whether the metric name should be modified to match normalization rules as defined [here](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/README.md): - `prometheus.query.normalize-calls` - `prometheus.query.normalize-duration` - Separate flags intentional to allow support for backwards compatibility with older OpenTelemetry Collector versions. A single flag is insufficient. - Motivated by a breaking change in: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.80.0. --------- Signed-off-by: albertteoh <see.kwang.teoh@gmail.com> Signed-off-by: Afzal Ansari <afzal442@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
prometheus.query.normalize-callsprometheus.query.normalize-duration