Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracegen] Add build info during compilation #4727

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • add build info to tracegen and anonymizer binaries

How was this change tested?

$ make build-tracegen
CGO_ENABLED=0 installsuffix=cgo go build -trimpath -ldflags "-X github.com/jaegertracing/jaeger/pkg/version.commitSHA=f8c1523f64159bf05eedf6aa6ffb09c9402a9932 -X github.com/jaegertracing/jaeger/pkg/version.latestVersion=v1.48.0 -X github.com/jaegertracing/jaeger/pkg/version.date=2023-09-05T00:05:46Z" -o ./cmd/tracegen/tracegen-darwin-amd64 ./cmd/tracegen/main.go

$ ./cmd/tracegen/tracegen-darwin-amd64
2023-09-05T21:55:58.923-0400	INFO	./main.go:56	application version: git-commit=f8c1523f64159bf05eedf6aa6ffb09c9402a9932, git-version=v1.48.0, build-date=2023-09-05T00:05:46Z

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 6, 2023 01:59
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit aa77e95 into jaegertracing:main Sep 6, 2023
@yurishkuro yurishkuro deleted the add-build-info branch September 6, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant