Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPM] Deprecate support for Spanmetrics Processor naming convention #4741

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add deprecation notice to CLI flag
  • Add log message when using span metrics processor notation

How was this change tested?

$ go run ./cmd/all-in-one help
      --prometheus.query.support-spanmetrics-connector            (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)  Controls whether the metrics queries should match the OpenTelemetry Collector's spanmetrics connector naming (when true) or spanmetrics processor naming (when false). (default true)

$ PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR=false METRICS_STORAGE_TYPE=prometheus go run ./cmd/all-in-one
2023/09/09 20:29:19 using Spanmetrics Processor's metrics naming conventions (deprecated, will be removed after 2024-01-01 or in release v1.53.0, whichever is later)

cc @albertteoh

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
plugin/metrics/prometheus/options.go 100.00%

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit a15f3a3 into jaegertracing:main Sep 10, 2023
@yurishkuro yurishkuro deleted the part-of-4736 branch September 10, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants