Add e2e test for sampling storage #4772

slayer321 · 2023-09-22T12:01:06Z

Which problem is this PR solving?

Related Storage backends for adaptive sampling #3305

Description of the changes

Adding e2e test for Implemented Storage backends for adaptive sampling i.e (cassendra, in-memory)

How was this change tested?

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

codecov · 2023-09-22T13:09:07Z

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
plugin/storage/integration/integration.go	`73.86% <77.77%> (+0.67%)`	⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

plugin/storage/integration/integration.go

plugin/storage/integration/cassandra_test.go

plugin/storage/integration/integration.go

plugin/storage/integration/memstore_test.go

plugin/storage/integration/integration.go

Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>

yurishkuro reviewed Sep 24, 2023

View reviewed changes

plugin/storage/integration/integration.go Outdated Show resolved Hide resolved

plugin/storage/integration/cassandra_test.go Outdated Show resolved Hide resolved

slayer321 force-pushed the e2e-test-for-sampling-store branch from b2fd20a to f819541 Compare September 25, 2023 12:31

slayer321 changed the title ~~[WIP] Add e2e test for sampling storage~~ Add e2e test for sampling storage Sep 25, 2023

slayer321 marked this pull request as ready for review September 25, 2023 12:37

slayer321 requested a review from a team as a code owner September 25, 2023 12:37

slayer321 requested a review from albertteoh September 25, 2023 12:37