Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose collector ports in all-in-one docker images #4810

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Expose collector ports in all-in-one docker images #4810

merged 1 commit into from
Oct 10, 2023

Conversation

arunvelsriram
Copy link
Contributor

@arunvelsriram arunvelsriram commented Oct 6, 2023 •
edited
Loading

Which problem is this PR solving?

Resolved #4808

Description of the changes

  • Expose OTLP gRPC and HTTP Collector ports in all-in-one Docker image.
  • Expose all collector ports in collector Docker image

How was this change tested?

Checklist

@arunvelsriram arunvelsriram requested a review from a team as a code owner October 6, 2023 14:51
@arunvelsriram arunvelsriram changed the title Expose OTLP collector ports in all-in-one image Expose OTLP collector ports in docker images Oct 6, 2023
@yurishkuro
Copy link
Member

do you want to fix cmd/collector/Dockerfile too? It's missing most ports

@arunvelsriram
Copy link
Contributor Author

Shall I expose all collector ports in the collector docker file as part of this PR?

@arunvelsriram
Copy link
Contributor Author

do you want to fix cmd/collector/Dockerfile too? It's missing most ports

done

@arunvelsriram arunvelsriram changed the title Expose OTLP collector ports in docker images Expose collector ports in docker images Oct 6, 2023
yurishkuro
yurishkuro reviewed Oct 6, 2023
View reviewed changes
cmd/collector/Dockerfile Outdated Show resolved Hide resolved
@arunvelsriram
Expose all collector ports in all-one-one and collector docker image
600e214 
Signed-off-by: Arunvel Sriram <arunvelsriram@gmail.com>
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 45afe75 into jaegertracing:main Oct 10, 2023
31 checks passed
@yurishkuro
Copy link
Member

thanks 🎉

@yurishkuro yurishkuro changed the title Expose collector ports in docker images Expose collector ports in all-in-one docker images Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Expose OTLP Ports in all-in-one docker image
2 participants
@arunvelsriram @yurishkuro