Clean up CI scripts and prune Docker images between builds #4815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
commented
Oct 7, 2023
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| set -exu | |||
|
|
|||
| BRANCH=${BRANCH:?'missing BRANCH env var'} | |||
There was a problem hiding this comment.
not used in this script
yurishkuro
commented
Oct 7, 2023
| @@ -26,5 +26,4 @@ if [[ $body != *"Rides On Demand"* ]]; then | |||
| fi | |||
| docker rm -f $CID | |||
|
|
|||
| BRANCH=${BRANCH:?'missing BRANCH env var'} | |||
There was a problem hiding this comment.
not used in this script
yurishkuro
commented
Oct 7, 2023
| temp_file=$(mktemp) | ||
| trap "rm -f ${temp_file}" EXIT | ||
| release_url="https://github.com/jaegertracing/jaeger-ui/releases/download/${LAST_TAG}/assets.tar.gz" | ||
| release_url="https://github.com/jaegertracing/jaeger-ui/releases/download/${last_tag}/assets.tar.gz" |
There was a problem hiding this comment.
just a refactoring to use lowercase names for variables
albertteoh
reviewed
Oct 7, 2023
Comment on lines
+74
to
+75
| docker buildx prune --all --verbose | ||
| docker system prune |
There was a problem hiding this comment.
We might need to add --force for each of these to avoid being prompted for confirmation.
yurishkuro
added
the
changelog:ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?