Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Keep the UI asset's .gz file timestamps the same as the original file #4879

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Oct 22, 2023

Which problem is this PR solving?

  • make rebuild-ui and make build-ui did not update the UI assets according to the latest release

Description of the changes

  • This changes the timestamp of the copied index.html.gz asset file to match the timestamp of the original asset. In turn, the timestamp of that asset matches the date of the UI release. This allows the combination of rebuild/build targets to always bring the UI assets in sync with the actual commit pinned in the ui-submodule.

How was this change tested?

  • validated that CI runs normally
  • ran manually on different versions of UI to ensure assets get copied again

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 22, 2023 00:54
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 22, 2023
@yurishkuro yurishkuro merged commit 3b47d6b into jaegertracing:main Oct 22, 2023
33 of 34 checks passed
@yurishkuro yurishkuro deleted the makefile branch October 22, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant