Split unit-test workflow into tests and lint #4933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
|
Hello @yurishkuro can you please review the PR and guide if any changes needed |
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
yurishkuro
reviewed
Nov 6, 2023
Comment on lines
18
to
24
| env: | ||
| # Using upload token helps against rate limiting errors. | ||
| # Cannot define it as secret as we need it accessible from forks. | ||
| # See https://github.com/codecov/codecov-action/issues/837 | ||
| CODECOV_TOKEN: f457b710-93af-4191-8678-bcf51281f98c | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| env: | |
| # Using upload token helps against rate limiting errors. | |
| # Cannot define it as secret as we need it accessible from forks. | |
| # See https://github.com/codecov/codecov-action/issues/837 | |
| CODECOV_TOKEN: f457b710-93af-4191-8678-bcf51281f98c |
| @@ -50,6 +50,3 @@ jobs: | |||
| flags: unittests | |||
| fail_ci_if_error: true | |||
| token: ${{ env.CODECOV_TOKEN }} | |||
|
|
|||
There was a problem hiding this comment.
also remove make install-test-tools above
yurishkuro
reviewed
Nov 6, 2023
yurishkuro
added
the
changelog:ci
Signed-off-by: MeenuyD <meenu.coninja@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Meenu Yadav <116630390+MeenuyD@users.noreply.github.com>
yurishkuro
approved these changes
Nov 6, 2023
yurishkuro
changed the title
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr splits the unit-test workflow into two parallel workflows: one for running tests and another for running linters. The motivation behind this change is to improve the overall workflow performance. The unit-test workflow had become the longest among all workflows, with significant time spent on installing tools that are only required for linters.
Resolves #4930