[SPM] Differentiate null from no error data #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2023 20:04
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
Signed-off-by: Albert Teoh <albert@packsmith.io>
albertteoh
commented
Dec 3, 2023
| @@ -2,7 +2,7 @@ | |||
| build: export DOCKER_TAG = dev | |||
| build: clean-jaeger | |||
| cd ../../ && \ | |||
| make build-all-in-one && \ | |||
| make build-all-in-one-linux && \ | |||
There was a problem hiding this comment.
The docker images rely on linux binaries.
| @@ -211,7 +211,38 @@ func (m MetricsReader) GetErrorRates(ctx context.Context, requestParams *metrics | |||
| ) | |||
| }, | |||
| } | |||
| return m.executeQuery(ctx, metricsParams) | |||
| errorMetrics, err := m.executeQuery(ctx, metricsParams) | |||
There was a problem hiding this comment.
This is the main change, the rest supports this change, mostly for testing purposes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4985 +/- ##
==========================================
- Coverage 95.60% 95.60% -0.01%
==========================================
Files 319 319
Lines 18764 18786 +22
==========================================
+ Hits 17940 17960 +20
- Misses 661 663 +2
Partials 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Albert Teoh <albert@packsmith.io>
yurishkuro
approved these changes
Dec 3, 2023
| @@ -62,13 +62,13 @@ make build | |||
| ## Bring up the dev environment | |||
|
|
|||
| ```bash | |||
| make run-dev | |||
| make dev | |||
There was a problem hiding this comment.
Would it make sense to add a ci workflow that will build and run this example like that?
There was a problem hiding this comment.
Interesting idea, thanks. I'll have a think about this and put together a separate PR for it.
|
Thanks for the review! |
RipulHandoo
pushed a commit
to RipulHandoo/jaeger
that referenced
this pull request
Dec 4, 2023
## Which problem is this PR solving? - Resolves jaegertracing#4229 ## Description of the changes - Ensures SPM displays a 0% error rate if there are no error metrics _and_ call rates exist. - If call rates don't exist, the error rate will also be null. - This ensures SPM is able to differentiate "no data" from "no errors". ## How was this change tested? - Add unit tests to cover happy and error cases. - Tested locally to confirm "No data" is shown in the Error graph when there is no data, then when call rates are available, a 0% rate is displayed. <img width="1710" alt="Screenshot 2023-12-03 at 8 01 36 pm" src="https://github.com/jaegertracing/jaeger/assets/26584478/e38bdefc-2e2e-4a9c-a873-2ad1857f2098"> <img width="1696" alt="Screenshot 2023-12-03 at 8 00 45 pm" src="https://github.com/jaegertracing/jaeger/assets/26584478/3e10d5fb-03e4-4ff3-b260-0dd8045eafbe"> ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Albert Teoh <albert@packsmith.io> Co-authored-by: Albert Teoh <albert@packsmith.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test