-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add goleak check in tests that do not fail #5025
add goleak check in tests that do not fail #5025
Conversation
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@akagami-harsh some packages do fail, e.g.
What method did you use to validate "tests that do not fail"? |
Signed-off-by: Yuri Shkuro <github@ysh.us>
The integration package contains numerous conditions (build tags and env var checks) that disable/enable various storage tests, so it's difficult to test locally to ensure full coverage. I removed it for now. |
i tested it locally by using |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
==========================================
- Coverage 95.62% 95.61% -0.02%
==========================================
Files 319 319
Lines 18786 18786
==========================================
- Hits 17965 17963 -2
- Misses 659 661 +2
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Which problem is this PR solving?
Description of the changes
check-goleak-file.sh
make goleak
was listing directories that do not contain any test, added aif
condition to prevent thatHow was this change tested?
make test