-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test summary reports #5126
Conversation
Signed-off-by: Albert Teoh <albert@packsmith.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5126 +/- ##
==========================================
+ Coverage 95.59% 95.60% +0.01%
==========================================
Files 322 322
Lines 18454 18454
==========================================
+ Hits 17641 17643 +2
+ Misses 653 651 -2
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Makefile
Outdated
@@ -455,10 +454,6 @@ install-ci: install-test-tools install-build-tools | |||
test-ci: GOTEST := $(GOTEST_QUIET) -json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, good catch; thanks! Removed -json
flag in: 5675e49
Signed-off-by: Albert Teoh <albert@packsmith.io>
Note the test is failing on "Download and extract artifacts" but this should no longer exist once this PR is merged into main. |
Thanks! |
Which problem is this PR solving?
Description of the changes
Checklist