-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kafka-producer] Support setting max message size #5263
[kafka-producer] Support setting max message size #5263
Conversation
Signed-off-by: Saketh kappala <43525626+sappusaketh@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Saketh <43525626+sappusaketh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5263 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 339 339
Lines 16503 16510 +7
=======================================
+ Hits 15693 15700 +7
Misses 621 621
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
## Which problem is this PR solving? - PR #5263 added support for setting max message size a producer can send that solved the issue on collector end now we are seeing our consumer getting stuck consuming messages larger that 1MB(default fetch max message bytes) so adding an option to set this value via flags ## Description of the changes - adding an option to set fetch max message bytes value via flags ## How was this change tested? - Tested against our dev jaeger where we have spans larger than 1 MB ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Saketh kappala <43525626+sappusaketh@users.noreply.github.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test