Refactor healthcheck signalling between server and service #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the signalling of healthcheck status from the "servers" to the "service": instead of using 2 channels to feed healthcheck status back to the Service.HealthCheck, we just give the server components direct access to the Healthcheck which they can update directly. This is possible because the Healthcheck package is threadsafe (uses `atomic.Value` for state). This pattern is consisten with how the service's Healtcheck is passed directly to cmd/collector/app package. closes jaegertracing#5307 Signed-off-by: Will Sewell <willsewell@monzo.com>
WillSewell
commented
Mar 28, 2024
| @@ -48,23 +48,23 @@ import ( | |||
| // Server runs HTTP, Mux and a grpc server | |||
| type Server struct { | |||
| logger *zap.Logger | |||
| healthCheck *healthcheck.HealthCheck | |||
There was a problem hiding this comment.
I felt like this was nicer ordering because this felt related to the logger to me since they both come from the service and are both related to "reporting status".
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5308 +/- ##
==========================================
- Coverage 95.09% 95.06% -0.04%
==========================================
Files 340 340
Lines 16626 16612 -14
==========================================
- Hits 15811 15792 -19
- Misses 628 631 +3
- Partials 187 189 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Mar 28, 2024
yurishkuro
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #5307
Description of the changes
atomic.Valuefor state).How was this change tested?
make lint testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test