-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security files and other governance files for best practices #5365
Conversation
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
They can merge their own patches or patches from others. The current maintainers can be found in [CODEOWNERS](./CODEOWNERS). | ||
They can merge their own patches or patches from others. The current maintainers can be found in [MAINTAINERS](./MAINTAINERS.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good pickup.
|
||
| Name | Employer | Responsibilities | | ||
| ---- | -------- | ---------------- | | ||
| [@albertteoh](https://github.com/albertteoh) | PackSmith | All | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other ALLs are upper-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to fix this? ^
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5365 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 343 343
Lines 16777 16777
=======================================
Hits 15974 15974
Misses 605 605
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…aegertracing#5365) Only changes in md for this one Adding MAINTAINERS.md, and fixing a 404 in GOVERNANCE.md Fixing CODE_OF_CONDUCT per template : https://github.com/cncf/project-template/blob/main/CODE_OF_CONDUCT.md Working on : jaegertracing#5363 --------- Signed-off-by: Jonah Kowall <jkowall@kowall.net> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Only changes in md for this one
Adding MAINTAINERS.md, and fixing a 404 in GOVERNANCE.md
Fixing CODE_OF_CONDUCT per template : https://github.com/cncf/project-template/blob/main/CODE_OF_CONDUCT.md
Working on : #5363