Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up README badges and adding CLOMonitor #5371

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fixing up README badges and adding CLOMonitor #5371

merged 1 commit into from
Apr 18, 2024

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Apr 17, 2024

Which problem is this PR solving?

Improvements for #5363

Description of the changes

I have fixed the variables for the badge management and also added our badge for CLOMontior which is what the CNCF seems to be using most often.

How was this change tested?

Viewed the README.md and badges

Checklist

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
@jkowall jkowall added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Apr 17, 2024
@jkowall jkowall requested a review from a team as a code owner April 17, 2024 22:25
@jkowall jkowall requested a review from joe-elliott April 17, 2024 22:25
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (ceb1d25) to head (ec6390e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5371   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         343      343           
  Lines       16781    16781           
=======================================
  Hits        15976    15976           
  Misses        606      606           
  Partials      199      199           
Flag Coverage Δ
badger 10.51% <ø> (ø)
cassandra-3.x 18.42% <ø> (ø)
cassandra-4.x 18.42% <ø> (ø)
elasticsearch-5.x 20.87% <ø> (-0.02%) ⬇️
elasticsearch-6.x 20.87% <ø> (ø)
elasticsearch-7.x 20.92% <ø> (-0.02%) ⬇️
elasticsearch-8.x 21.11% <ø> (-0.02%) ⬇️
grpc 14.59% <ø> (ø)
kafka 10.17% <ø> (ø)
opensearch-1.x 20.98% <ø> (ø)
opensearch-2.x 20.98% <ø> (ø)
unittests 91.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 1c60efc into jaegertracing:main Apr 18, 2024
38 checks passed
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request May 3, 2024
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants