Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grpc-plugin storage type name with just grpc #5442

Merged
merged 2 commits into from
May 12, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented May 11, 2024

Which problem is this PR solving?

Description of the changes

  • Add new storage type grpc and log warning if the old value grpc-plugin is used.

How was this change tested?

  • CII

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.48%. Comparing base (98abc11) to head (130f1af).

Files Patch % Lines
plugin/storage/factory_config.go 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5442      +/-   ##
==========================================
- Coverage   95.50%   95.48%   -0.03%     
==========================================
  Files         331      331              
  Lines       16107    16113       +6     
==========================================
+ Hits        15383    15385       +2     
- Misses        551      555       +4     
  Partials      173      173              
Flag Coverage Δ
badger_v1 8.07% <0.00%> (-0.01%) ⬇️
badger_v2 1.94% <0.00%> (-0.01%) ⬇️
cassandra-3.x-v1 16.48% <0.00%> (-0.02%) ⬇️
cassandra-3.x-v2 1.86% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1 16.48% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2 1.86% <0.00%> (-0.01%) ⬇️
elasticsearch-7.x 1.78% <0.00%> (?)
elasticsearch-8.x 1.78% <0.00%> (?)
grpc_v1 9.12% <11.11%> (-0.01%) ⬇️
grpc_v2 7.49% <0.00%> (+<0.01%) ⬆️
kafka 9.81% <0.00%> (-0.01%) ⬇️
opensearch-1.x 1.77% <0.00%> (?)
opensearch-2.x 1.77% <0.00%> (?)
unittests 93.99% <33.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 84ea40e into jaegertracing:main May 12, 2024
37 of 38 checks passed
@yurishkuro yurishkuro deleted the remove-grpc-plugin-type branch May 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deprecation] Phase out grpc-plugin storage (sidecar via hashicorp-plugin)
2 participants