Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Replace e2e span_reader grpc.DialContext with NewClient #5443

Merged
merged 1 commit into from
May 12, 2024

Conversation

james-ryans
Copy link
Contributor

@james-ryans james-ryans commented May 12, 2024

Which problem is this PR solving?

Description of the changes

  • Replaces grpc.DialContext with NewClient at cmd/jaeger/internal/integration/span_reader.go

How was this change tested?

  • Run STORAGE=grpc SPAN_STORAGE_TYPE=memory make jaeger-v2-storage-integration-test locally.

Checklist

Signed-off-by: James Ryans <james.ryans2012@gmail.com>
@james-ryans james-ryans requested a review from a team as a code owner May 12, 2024 16:04
@james-ryans james-ryans requested a review from pavolloffay May 12, 2024 16:04
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (a2a9188) to head (3cdcdd0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5443   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         331      331           
  Lines       16115    16115           
=======================================
  Hits        15385    15385           
  Misses        556      556           
  Partials      174      174           
Flag Coverage Δ
badger_v1 8.07% <ø> (ø)
badger_v2 1.94% <ø> (?)
cassandra-3.x-v1 16.48% <ø> (ø)
cassandra-3.x-v2 1.86% <ø> (?)
cassandra-4.x-v1 16.48% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (+0.01%) ⬆️
elasticsearch-8.x 1.78% <ø> (+0.01%) ⬆️
grpc_v1 9.12% <ø> (ø)
grpc_v2 7.48% <ø> (-0.02%) ⬇️
kafka 9.81% <ø> (ø)
opensearch-1.x 1.77% <ø> (?)
opensearch-2.x 1.78% <ø> (?)
unittests 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 12, 2024
@yurishkuro yurishkuro merged commit 5757c56 into jaegertracing:main May 12, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from grpc.Dial to grpc.NewClient
2 participants