-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[remote-storage] Add healthcheck to grpc server #5461
[remote-storage] Add healthcheck to grpc server #5461
Conversation
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5461 +/- ##
==========================================
+ Coverage 95.46% 95.48% +0.01%
==========================================
Files 331 331
Lines 16112 16121 +9
==========================================
+ Hits 15382 15393 +11
+ Misses 556 555 -1
+ Partials 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does grpc automatically use this service? I was thinking that in the test we would need to loop-query it until we get a green response.
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@@ -82,7 +82,7 @@ func (r *spanReader) GetTrace(ctx context.Context, traceID model.TraceID) (*mode | |||
for i := range received.Spans { | |||
spans = append(spans, &received.Spans[i]) | |||
} | |||
r.logger.Info(fmt.Sprintf("GetTrace received %d spans (total %d)", len(received.Spans), len(spans))) | |||
// r.logger.Info(fmt.Sprintf("GetTrace received %d spans (total %d)", len(received.Spans), len(spans))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-ryans are you sure we need this log? It's very noisy, I don't think it adds much value other than a form of progress reporting (which I would do with much lighter approach, maybe logging every 1000 spans)
Signed-off-by: Yuri Shkuro <github@ysh.us>
No, It doesn't. You're right, the loop-query will do this. I've made changes to my local but you already helped with this, thank you!
Log the total retrieved spans would already be helpful, I never thought we would get 10 spans for each retrieval before. Thank you for the changes. |
Might have introduced this race https://github.com/jaegertracing/jaeger/actions/runs/9154252555/job/25164498035?pr=5465#step:8:16 Usually it's a sign of opportunistic shutdown where Close returns before bg routines exit and they continue calling the logger after the test was ended.
|
Which problem is this PR solving?
Description of the changes
testzap
loggers include source fileHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test