Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Processor to PostAggregator #5479

Merged
merged 1 commit into from
May 24, 2024

Conversation

Pushkarm029
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Rename Processor to PostAggregator

How was this change tested?

  • make test

Checklist

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 requested a review from a team as a code owner May 23, 2024 08:15
@Pushkarm029 Pushkarm029 requested a review from pavolloffay May 23, 2024 08:15
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (901165c) to head (6101610).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         331      331           
  Lines       16155    16155           
=======================================
  Hits        15432    15432           
  Misses        548      548           
  Partials      175      175           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (ø)
elasticsearch-8.x 1.78% <ø> (+0.01%) ⬆️
grpc_v1 9.51% <ø> (-0.02%) ⬇️
grpc_v2 7.58% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1.x 1.76% <ø> (ø)
opensearch-2.x 1.78% <ø> (ø)
unittests 93.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label May 24, 2024
@yurishkuro yurishkuro merged commit 584b6ff into jaegertracing:main May 24, 2024
38 of 39 checks passed
@Pushkarm029 Pushkarm029 deleted the postaggregator branch May 24, 2024 16:54
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request Jun 2, 2024
## Which problem is this PR solving?
-
jaegertracing#5441 (comment)

## Description of the changes
- Rename `Processor` to `PostAggregator`

## How was this change tested?
- `make test`

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants