-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker compose for kafka integration tests #5500
Conversation
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5500 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 327 327
Lines 16012 16012
=======================================
Hits 15401 15401
Misses 436 436
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please write informative PR title and description
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
please have a look at dependabot then I will add it for both elaticsearch/opensearch and kafka |
Signed-off-by: Your Name <you@example.com>
@yurishkuro as you can see when the |
Signed-off-by: Your Name <you@example.com>
interval: daily | ||
allow: | ||
- dependency-name: "docker.elastic.co/elasticsearch/elasticsearch" | ||
update-types: ["version-update:semver-minor"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat, I didn't know this was possible, and it addresses one of my concerns in the ticket (to avoid it auto-upgrade 7x -> 8x)
@yurishkuro can you have a look at this should I include this issue in this pr only ? |
Yeah, you can add that here. I think it would be better to keep the encapsulation and not require the workflow to know the exact file name - similar to |
Signed-off-by: Your Name <you@example.com>
Signed-off-by: Your Name <you@example.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## Which problem is this PR solving? Part of jaegertracing#5485 ## Description of the changes * In `script/kafka-integration-test.sh` initialized kafka by docker compose * updated `.github/workflow/ci-kafka.yml` to take logs from docker compose * added comments in `script/kafka-integration-test.sh` and fixed a typo * add new locations to dependabot config to allow it to upgrade versions in the new docker compose files ## How was this change tested? - CI ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Your Name <you@example.com> Signed-off-by: mehul gautam <mehulsharma4786@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Your Name <you@example.com> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Which problem is this PR solving?
Part of #5485
Description of the changes
script/kafka-integration-test.sh
initialized kafka by docker compose.github/workflow/ci-kafka.yml
to take logs from docker composescript/kafka-integration-test.sh
and fixed a typoHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test