Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual DCO check using Python script dco-check #5528

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 4, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Ran the script manually:

$ python3 scripts/dco_check.py -b main
Detected: git (default)

Checking commits: 5863430fa0c22679ff843abdd717ac8cf8fb6828..7a5e58b97d16f3ea024cb5da23442e6833798429

All good!

With an unsigned commit:

$ gca -m bad
[manual-dco-check 7da95684] bad
 1 file changed, 1 insertion(+)

$ python3 scripts/dco_check.py -b main
Detected: git (default)

Checking commits: 5863430fa0c22679ff843abdd717ac8cf8fb6828..7da95684408ebd3f32692e9444940bdf0e04348d

Missing sign-off(s):

	7da95684408ebd3f32692e9444940bdf0e04348d
		no sign-off found

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 4, 2024 04:47
@yurishkuro yurishkuro requested a review from albertteoh June 4, 2024 04:47
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 4, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (5863430) to head (58237ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5528      +/-   ##
==========================================
+ Coverage   96.19%   96.20%   +0.01%     
==========================================
  Files         327      327              
  Lines       16013    16013              
==========================================
+ Hits        15403    15405       +2     
+ Misses        435      434       -1     
+ Partials      175      174       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.44% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.44% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7-v1 18.88% <ø> (ø)
elasticsearch-8-v1 19.07% <ø> (ø)
elasticsearch-8-v2 19.08% <ø> (ø)
grpc_v1 9.47% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1-v1 18.94% <ø> (ø)
opensearch-2-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2-v2 18.92% <ø> (-0.02%) ⬇️
unittests 93.89% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit b295383 into jaegertracing:main Jun 4, 2024
39 checks passed
@yurishkuro yurishkuro deleted the manual-dco-check branch June 4, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants